Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds condition of testing #68

Merged
merged 10 commits into from
Aug 28, 2024
Merged

adds condition of testing #68

merged 10 commits into from
Aug 28, 2024

Conversation

capetillo
Copy link
Collaborator

@capetillo capetillo commented Aug 27, 2024 •
edited
Loading

TEST: Format Time utils

Added tests to test the functions of formatTime utils functions and .yaml file to run github actions

mgdaily
mgdaily reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@mgdaily mgdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a lil confused about tests that are claiming to be for invalid dates but are returning valid date strings

src/tests/unit/utils/formatTime.test.js Outdated Show resolved Hide resolved
src/tests/unit/utils/formatTime.test.js Show resolved Hide resolved
@capetillo capetillo requested a review from mgdaily August 28, 2024 18:18
mgdaily
mgdaily approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@mgdaily mgdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@capetillo capetillo merged commit 3f5d5af into main Aug 28, 2024
1 check passed
@capetillo capetillo deleted the test/formattime branch August 28, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgdaily mgdaily mgdaily approved these changes

@jnation3406 jnation3406 Awaiting requested review from jnation3406

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capetillo @mgdaily